Skip to content

feat: Expose cache hits in list_files_cache function#23439

Open
mkleen wants to merge 2 commits into
apache:mainfrom
mkleen:list_files_cache_hits
Open

feat: Expose cache hits in list_files_cache function#23439
mkleen wants to merge 2 commits into
apache:mainfrom
mkleen:list_files_cache_hits

Conversation

@mkleen

@mkleen mkleen commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes None.

Rationale for this change

Follow up to #22613 and #23253. Cache hits are now supported for all memory-limiting caches. Therefore it makes sense to expose them in the list_files_cache function the same way the metadata_cache and statistics_cache functions do it already.

What changes are included in this PR?

  • Add cache hits to the list_files_cache function
  • Tests
  • Adapt documentation for the list_files_cache function

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes, the list_files_cache function supports now cache hits but no breaking changes.

@mkleen mkleen force-pushed the list_files_cache_hits branch from bdd34a1 to 3e5fa6c Compare July 10, 2026 07:36
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 10, 2026
@mkleen mkleen marked this pull request as ready for review July 10, 2026 07:45

@nuno-faria nuno-faria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkleen, I manually confirmed this with datafusion-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants